General discussion on installation and configuration of SOGo

Text archives Help


Re: [SOGo] Encoding of Arabic (Windows-12256) Not Work


Chronological Thread 
  • From: "\"Christian M. Jensen\"" ( ) < >
  • To:
  • Subject: Re: [SOGo] Encoding of Arabic (Windows-12256) Not Work
  • Date: Wed, 10 Jul 2019 19:01:51 +0200
  • Dmarc-filter: OpenDMARC Filter v1.2.0 mail.inverse.ca A89F21DE500F

hi again.

Just Tested hate leaving thing untested. Works yay! i attached path, this only adds  windows-1256 like i wrote earlier.


On 10-07-2019 18:10, "Christian M. Jensen" ( ) wrote:

Hi.

Just tested a bit and can confirm this is an issue, and i think the problem is that SOGo has no rules for charset windows-1256 like for others as seen here.

https://github.com/inverse-inc/sogo/blob/60247e83e7da798bb7292521694812a6ea12ff0f/UI/MailPartViewers/UIxMailPartHTMLViewer.m#L82-L85

My suggesting is that you add this '{ @"windows-1256", XML_CHAR_ENCODING_ERROR},'  to UIxMailPartHTMLViewer.m between line 82/85 and compile SOGo to see if that helps, and report back.

Now this just a suggestion not tested so can't say if it will work. The reason i think this is where the issue resides, is as you can see by the image, title is fine but body is not, and the body part of the mail "look like" it parses through that method.


That's just my suggestion, hope you figure out what the root cause is.

-- 
Hilsen/Regards
Christian M. Jensen
-- 
Hilsen/Regards
Christian M. Jensen

PNG image

PNG image

Description: Added encoding windows-1256
Fixes invalid coding when sending mails with Arabic letters, when sendt from
Windows.
.
sogo (4.0.7.20190710-1) DIST; urgency=low
.
* updated to 4.0.7.20190710
Author: Christian M. Jensen
< >

---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:

Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: https://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: 2019-07-10

--- sogo-4.0.7.20190710.orig/UI/MailPartViewers/UIxMailPartHTMLViewer.m
+++ sogo-4.0.7.20190710/UI/MailPartViewers/UIxMailPartHTMLViewer.m
@@ -82,6 +82,7 @@ _xmlCharsetForCharset (NSString *charset
{ @"windows-1250", XML_CHAR_ENCODING_ERROR}, // unsupported, will
trigger windows-1250 -> utf8 conversion
{ @"windows-1251", XML_CHAR_ENCODING_ERROR}, // unsupported, will
trigger windows-1251 -> utf8 conversion
{ @"windows-1255", XML_CHAR_ENCODING_ERROR}, // unsupported, will
trigger windows-1255 -> utf8 conversion
+ { @"windows-1256", XML_CHAR_ENCODING_ERROR},
{ @"windows-1257", XML_CHAR_ENCODING_ERROR}, // unsupported, will
trigger windows-1257 -> utf8 conversion
{ @"gb2312", XML_CHAR_ENCODING_ERROR}, // unsupported, will
trigger gb2312 -> utf8 conversion
{ @"gbk", XML_CHAR_ENCODING_ERROR}, // unsupported, will
trigger gb2312 -> utf8 conversion


Archive powered by MHonArc 2.6.18.

Top of page